fix:/prefer the use of column identity over ordinals#4211
Open
johnbrk wants to merge 2 commits intolaunchbadge:mainfrom
Open
fix:/prefer the use of column identity over ordinals#4211johnbrk wants to merge 2 commits intolaunchbadge:mainfrom
johnbrk wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
barry3406
reviewed
Apr 9, 2026
Contributor
barry3406
left a comment
barry3406
left a comment
There was a problem hiding this comment.
Nice catch — the ordinal-vs-name mismatch in query_as! has bitten a few people.
One thing I noticed: this only switches to column-name lookup for the (true, ColumnType::Exact) branch, but the Wildcard, OptWildcard, and (false, _) arms still use #i (the ordinal). If the column order can differ at runtime (the exact scenario in #4210), those branches would still break. Was that intentional, or should they also use stringify!(#column_ident)?
Also minor: quote::format_ident!("{}", ident) is a no-op when ident is already an Ident — you can pass &ident directly into the quote! interpolation and stringify!(#ident) will work the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #4210
Is this a breaking change?
No, just makes
query_as!behave more likequery_as